ci: harden website e2e and examples deploy gating#204
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the website e2e and examples deploy gates without changing the overall CI topology.
localhost:3000to an isolated127.0.0.1:4308.PLAYWRIGHT_REUSE_EXISTING_SERVER=trueis set explicitly.libs/angular, includinglanggraph,ag-ui,a2ui,partial-json, andexample-layouts.Root Cause
The website e2e config could attach to whatever happened to be running on local port 3000, which can make local verification test the wrong app. The examples deploy gate also still referenced a removed
libs/angularpath and missed libraries that are now part of the example apps' runtime surface.Verification
npx nx e2e website --skip-nx-cache— 11 passednpx nx lint website --skip-nx-cache— passed with existingapps/website/instrumentation-client.tsnon-null assertion warningnpx nx build website --skip-nx-cachepython3parsed.github/workflows/ci.ymlwith PyYAMLgit diff --check