ci(release): enforce atomic package versions#179
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a release preflight that prevents publishing the fixed
publishablegroup unless every publishable@ngaf/*package has one uniform version.The guard also verifies tag-triggered publishes use a
vX.Y.Ztag that matches the package version, while workflow-dispatch dry runs skip tag comparison because they run on branch refs.Notes
This intentionally does not normalize the currently skewed package versions. Until the planned manual normalization lands on
main, the preflight will fail release attempts and print the current package/version mismatch.Validation
npx vitest run scripts/verify-release-versions.spec.mjsnode --check scripts/verify-release-versions.mjs && node --check scripts/verify-release-versions.spec.mjsnpx prettier --check .github/workflows/publish.yml scripts/verify-release-versions.mjs scripts/verify-release-versions.spec.mjsnode scripts/verify-release-versions.mjs --tag v0.0.12exits 1 with the expected current version-skew report