[codex] Align production smoke checks with chat demos#124
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updates the production smoke suite to use the actual readiness signals for the primitive chat demos.
chat/messages,chat/input, andchat/debugrender message-input primitives directly instead of a<chat>host element, so the previous smoke check produced false failures even though the pages were healthy.chat/a2uialso returns an A2UI form surface rather than a visible markdown chat bubble, so its send/receive smoke test now waits for the renderedContact Usform heading instead of.chat-md.Why
The broader production smoke coverage already on
mainexposed three false negatives and one mismatched send/receive assertion. This patch keeps the smoke suite strict, but makes it route-aware where the UI contract differs.Verification
BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai npx playwright test apps/cockpit/e2e/production-smoke.spec.ts --grep "chat/messages loads|chat/input loads|chat/debug loads" --reporter=listBASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai npx playwright test apps/cockpit/e2e/production-smoke.spec.ts --reporter=listOPENAI_API_KEY=... BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai npx playwright test apps/cockpit/e2e/production-smoke.spec.ts --grep "chat/a2ui sends and receives a message" --reporter=listOPENAI_API_KEY=... BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai npx playwright test apps/cockpit/e2e/production-smoke.spec.ts --grep "sends and receives a message" --reporter=listgit diff --check