Add struct_eq builtin for member-wise struct comparisons#2801
Open
NotsoanoNimus wants to merge 4 commits intoc3lang:masterfrom
Open
Add struct_eq builtin for member-wise struct comparisons#2801NotsoanoNimus wants to merge 4 commits intoc3lang:masterfrom
struct_eq builtin for member-wise struct comparisons#2801NotsoanoNimus wants to merge 4 commits intoc3lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows comparisons of input structures that don't already have an
==overload (and it will just compare them anyway if they do). This reduces the need to define@operator(==)overrides which just doreturn self.a == self.a && self.b == self.b && ...;. They can now become something like this:This is especially useful when
memcmp-style comparisons of structs are not.You can also use the variadic arguments list to supply strings in dot-notation to exclude certain fields from being compared. See the unit tests for more information about how to do this.
The implementation is a bit redundant because there are no flow-control statements at compile-time. This could certainly use a few extra reviewers to ensure it works as broadly as possible, but tests seem to show a good coverage/capability.