menu: Remove ConstantName and ConstantValue from PartsMenu#1653
Open
menu: Remove ConstantName and ConstantValue from PartsMenu#1653
Conversation
These are internal helpers for the constant browser, not user-facing "extract parts" operations. Having them in PartsMenu confused users. Fixes c3d#1628 Signed-off-by: gnuduncan <gnuduncan@gmail.com>
Owner
|
Hi @duncanita. Thanks for reminding me about this one. I will not accept it as is, because the intent is for I will try to implement that fix today. |
Author
|
I'll try to rework this soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConstantNameandConstantValuefrom PartsMenu — they are internal helpers for the constant browser, not user-facing "extract parts" operationsFixes #1628
Test plan