src: Commands Map and Filter should not recurse#1649
Open
evgaster wants to merge 2 commits intoc3d:stablefrom
Open
src: Commands Map and Filter should not recurse#1649evgaster wants to merge 2 commits intoc3d:stablefrom
evgaster wants to merge 2 commits intoc3d:stablefrom
Conversation
With nested lists the commands Map and Filter operated not only on the top level list but recursively on the nested list(s) ... with the same provided rpl program. Removed the recursive processing of the elements of a list. Fixes: c3d#1648 Signed-off-by: Ed@vanGasteren.net
c3d
added a commit
that referenced
this pull request
Mar 9, 2026
The `map` function on the HP48 is supposed to be recursive. Document that fact. Related to #1649 Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
The HP 50g maps recursively. Most other programming languages map only on level. Introduce the flag MapRecursive / MapOneLevel. Both behaviours are now possible. Describes as such in the documentation. Fixes: c3d#1648 Signed-off-by: Ed@vanGasteren.net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With nested lists the commands Map and Filter operated not only on the top level list but recursively on the nested list(s) ... with the same provided rpl program.
Removed the recursive processing of the elements of a list for the filter command.
Introduced a MapRecursive / MapOneLevel flag to facilitate both behaviours.
The HP 50g does MapRecursive. DB48x rpl default does MapOneLevel, as most programming languages.
Fixes: #1648
Signed-off-by: Ed@vanGasteren.net