Skip to content

Improvements: load all plants from keymap file, added features in searching mode (not completed):#1641

Open
mipa83 wants to merge 31 commits intoc3d:stablefrom
mipa83:stable
Open

Improvements: load all plants from keymap file, added features in searching mode (not completed):#1641
mipa83 wants to merge 31 commits intoc3d:stablefrom
mipa83:stable

Conversation

@mipa83
Copy link

@mipa83 mipa83 commented Feb 27, 2026

changed keymap file and loading criteria: skip comments (//) till newline arrives.

Integrated the behaviour of Key_CHS, Key_RUN, Key_E (EEX) in handle_editing(key)
To maintain a better overview following functions (called them “editing”, because they should be used only in editing modus):
• bool editing_chs();
• bool editing_eex_or_cycle_prefixes();
• bool editing_spc_equal_semicolon();
CHS: changes -to +: example: ‘5-3 CHS --> 5+3 (old was ‘53’)
EEX: check if there is already an exponent, so beep and move there, otherwise exponent with or without leading 1.
spc_equal_semicolon() works now also with alpha and lowercase.
CAT working in alpha and lowercase mode
Annunciator line/Header: I got confused with alpha, lowercase and user mode: so I rewrote the labelling:
static cstring lbls[] = { " ", " A", " a", "U ", "UA", "Ua", "1 ", "1A", "1a", };

Commands are shown now also in editing mode: example: Dark “cos” after pressing COS is shown now also while editing…; Dark “cos” disappears when releasing the key.

SEARCH improvements
“DROP” and “DEL” reduces the selection from right and left.
“LEFT” and “RIGHT” reduce or expand the selection
Key_E (EEX): works with search (Settings.ExponentSeparator())

some Minor changes…

The search command is not fully done yet, because I am at a point where I need help.
What is working so fare:
example (no alpha) SIN –> adds S, then I, then N to the search commands: beep with exit at the first not found unicode.
I would like to improve more – but I could not find a selection criteria for key function: command, menu, else, … can you give me some help on this?

mipa83 added 30 commits January 22, 2026 10:27
Signed-off-by: mipa83 <mipa83@gmx.net>
TODOs - I need some help with
* excluding :
a) static const char numbers[]
b) static const char upper[]
c) static const char lower[] 
d) static const unicode shifted[] 
e) static const  unicode xshifted[] 
and using the object form .k48-file

Hey-Keybaord not supported yet
neg in "" not supportet yet

Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Comments need to start with “//”, ending with “\n” (newline).

Signed-off-by: mipa83 <mipa83@gmx.net>
because uses the same image background as db48.48k

Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Refactor user interface key handling functions and improve code clarity.

Signed-off-by: mipa83 <mipa83@gmx.net>
Removed unnecessary keyboard configurations from the array.

Signed-off-by: mipa83 <mipa83@gmx.net>
Removed obsolete image file aliases from resource.

Signed-off-by: mipa83 <mipa83@gmx.net>
Eliminated Bug with BASED mode, by adding  enable condition: !rt.editing()

Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
Updated key mappings for simulator (hold Shift key ⇧, hold Alt key ⎇ ) and corrected references for LastArg and Undo commands.

Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
changed keymap file and loading criteria: skip comments (//) till newline arrives.

Integrated the behaviour of Key_CHS, Key_RUN, Key_E in function handle_editing(key).
created functions (called them “editing”, because they work in editing mode): editing_chs(), editing_eex_or_cycle_prefixes(), editing_spc_equal_semicolon().

CHS: changes -to +: example: ‘5-3 CHS  5+3 (old was ‘53’)
EEX: check if there is already an exponent, so beep and move there, otherwise exponent with or without leading 1.
spc_equal_semicolon() works now also with alpha and lowercase.

CAT working in alpha and lowercase mode

Annunciator line/Header: I got confused with alpha, lowercase and user mode: so I rewrote the labelling:
static cstring lbls[] = { "  ", " A", " a", "U ", "UA", "Ua", "1 ", "1A", "1a", };

Commands are shown now also in editing mode: example: Dark “cos” holding COS is shown now also while editing…; Dark “cos” disappears when releasing the key.

SEARCH improvements: 
“DROP” and “DEL” reduces the selection from right and left.
“LEFT” and “RIGHT” reduce or expand the selection
10^x (EEX): works with search


Signed-off-by: mipa83 <mipa83@gmx.net>
load all plants from keymap file, improved search mode:
changed keymap file and loading criteria: skip comments (//) till newline arrives.

Integrated the behaviour of Key_CHS, Key_RUN, Key_E in function handle_editing(key).
created functions (called them “editing”, because they work in editing mode): editing_chs(), editing_eex_or_cycle_prefixes(), editing_spc_equal_semicolon().

CHS: changes -to +: example: ‘5-3 CHS  5+3 (old was ‘53’)
EEX: check if there is already an exponent, so beep and move there, otherwise exponent with or without leading 1.
spc_equal_semicolon() works now also with alpha and lowercase.

CAT working in alpha and lowercase mode

Annunciator line/Header: I got confused with alpha, lowercase and user mode: so I rewrote the labelling:
static cstring lbls[] = { "  ", " A", " a", "U ", "UA", "Ua", "1 ", "1A", "1a", };

Commands are shown now also in editing mode: example: Dark “cos” holding COS is shown now also while editing…; Dark “cos” disappears when releasing the key.

SEARCH improvements: 
“DROP” and “DEL” reduces the selection from right and left.
“LEFT” and “RIGHT” reduce or expand the selection
10^x (EEX): works with search

Signed-off-by: mipa83 <mipa83@gmx.net>
// comments till newline

Signed-off-by: mipa83 <mipa83@gmx.net>
…e_user before handle_editing)

changed keymap file and loading criteria: skip comments (//) till newline arrives.

Integrated the behaviour of Key_CHS, Key_RUN, Key_E in function handle_editing(key).
created functions (called them “editing”, because they work in editing mode): editing_chs(), editing_eex_or_cycle_prefixes(), editing_spc_equal_semicolon().

CHS: changes -to +: example: ‘5-3 CHS  5+3 (old was ‘53’)
EEX: check if there is already an exponent, so beep and move there, otherwise exponent with or without leading 1.
spc_equal_semicolon() works now also with alpha and lowercase.

CAT working in alpha and lowercase mode

Annunciator line/Header: I got confused with alpha, lowercase and user mode: so I rewrote the labelling:
static cstring lbls[] = { "  ", " A", " a", "U ", "UA", "Ua", "1 ", "1A", "1a", };

Commands are shown now also in editing mode: example: Dark “cos” holding COS is shown now also while editing…; Dark “cos” disappears when releasing the key.

SEARCH improvements: 
“DROP” and “DEL” reduces the selection from right and left.
“LEFT” and “RIGHT” reduce or expand the selection
10^x (EEX): works with search

Signed-off-by: mipa83 <mipa83@gmx.net>
Updated instructions for building the DB48X project, including WSL usage and cleanup commands.

Signed-off-by: mipa83 <mipa83@gmx.net>
Updated key mappings across various planes

Signed-off-by: mipa83 <mipa83@gmx.net>
Updated key mappings across various planes

Signed-off-by: mipa83 <mipa83@gmx.net>
Signed-off-by: mipa83 <mipa83@gmx.net>
@c3d
Copy link
Owner

c3d commented Mar 1, 2026

Hey, @mipa83, this looks very interesting, but I would really like to cut a 0.9.16. There has been no release for a while, and there is a regression in shift logic which is really annoying. So I will not merge that for this release, and put that on my to-do list list for 0.9.17.

Thanks a lot!

@c3d c3d added enhancement New feature or request user Reported by an actual user, yay! labels Mar 1, 2026
@mipa83
Copy link
Author

mipa83 commented Mar 13, 2026

Hey, @c3d , thanks for creating db48x - it is very useful :-)
Unfortunately, I created a lot of comments - some of them are very useless and confusing - so better you extract the modifications and add them directly or should I edit the code (on the latest stable version) and create new, better comments?

@c3d
Copy link
Owner

c3d commented Mar 13, 2026

Hi @mipa83 I think you mean "commits"? If so don't worry, I'll take care of that during the week-end. The problem is that you are touching really sensitive parts of the code and I want to make sure it works well.

@mipa83
Copy link
Author

mipa83 commented Mar 13, 2026

Yes, I did.
Just an other thought: splitting up (extracting) the stack operation from handle_editing(key) in an separate function might be a good idea for better code interpretation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request user Reported by an actual user, yay!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants