Allow to retain fetchEvent on all wasi 0.2.x versions#178
Merged
guybedford merged 3 commits intobytecodealliance:mainfrom Jan 16, 2025
Merged
Conversation
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
ba8c2ff to
b87cdb2
Compare
Contributor
Author
|
Are we okay bumping this to 4s? I see the last few commits have also failed on it. ComponentizeJS/test/builtins/performance.js Lines 24 to 27 in d8dd995 |
guybedford
suggested changes
Jan 16, 2025
guybedford
left a comment
There was a problem hiding this comment.
Yes, bumping CI to 4 or 5 seconds would be fine.
guybedford
approved these changes
Jan 16, 2025
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
0787fb3 to
775899a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the case where the guest wit states
wasi:http/incoming-handler@0.2.0but the engine exportswasi:http/incoming-handler@0.2.2.