Add support for game controllers with auto key binding and enable controller support for android#788
Conversation
…troller support for android Fixes bvschaik#787
|
For reference, this is untested. Hopefully @PhantomLordM can test it out for us! |
e314fbd to
0529a71
Compare
Thank you! |
Really sorry for the noob question, but...how could I download apk with those changes to test the features? |
|
Ah you're right, the Android build is not provided for pull requests. Building for Android manually is a big hassle too. I'll tell you what, I'll go ahead and add support in Augustus instead, do you mind testing using Augustus? Augustus is much more experimental than Julius anyway. Then if it works there, it can also be merged here. |
That's because it needs a signing key that's not provided for branches outside the repo. If you put the branch in the julius repo instead of your own it will upload an APK artifact. Another option: just go ahead and merge, we'll see on develop. |
|
No problem for me with testing it out on Augustus, also I have a few handhelds (four to be exact) so I could check it out on all of them, at least there'll be some brand/models variation. Please let me know when the feature would be implemented on Augustus. |
Eh, if you don't mind, it's less work for me! But did you look at the code yet? |
I had a quick peek and it looks fine to me at first glance. |
|
Nice, I'll merge then! @PhantomLordM as soon as it's built you can test! |
Hi, I run the 016d525 and the game reacts to controller input, but something is broken. What doesn't work: |
|
Ah, this is what I feared. Improper support. So, what's needed:
Since Julius is more stable, I'll move testing to Augusuts. I'll open an issue there, post commits for you to test (if you don't mind) then when things are working I'll backport the changes to Juius. Luckily I have a controller for Android so I can test it myself, but debugging for Android is terrible! |
I would love to help with testing, if that's ok with you. Just let me know please, when the new commit would be ready. |
Fixes #787