test: add comprehensive Playwright E2E test suite#3
Merged
Conversation
Add comprehensive security hardening to the NicTool web client: - CSRF protection: token-based validation on all state-changing operations (forms, delete links) with cookie + hidden field double-submit pattern - XSS output escaping: wrap all user-supplied values rendered in HTML with html_escape(), add js_escape() for JavaScript string contexts - Security headers: CSP, X-Frame-Options, X-Content-Type-Options, X-XSS-Protection, Referrer-Policy on all responses - Cookie hardening: HttpOnly, Secure, SameSite=Strict on session cookie - Add $res declaration to test files for strict mode compatibility Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 120 end-to-end tests covering the full NicTool web client: - Authentication (login, logout, session persistence) - CRUD operations (groups, zones, records, users, nameservers) - Delegation (zone/record delegation with permission variants) - Navigation (frameset, nav tree, section links) - Permissions (per-feature deny checks, self_write) - Search, sort, and pagination - Move operations (zones, users, nameservers between groups) - Log views (group, zone, record logs) - Security (CSRF enforcement, XSS protection, CSP compliance, cookie flags, security headers) - Delete UI (trash icon links with CSRF tokens) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
120 end-to-end tests covering the full NicTool web client using Playwright:
Running the tests
Test plan
🤖 Generated with Claude Code