Closed
Conversation
Contributor
|
+1 for getting this merged in.. |
Owner
|
Code needs to be fixed before it can be merged. Instead of modifying the build files, the source files need to be modified and then built. If anybody wants to update the pull request I can merge it. |
Author
|
i updated it .. #74 |
Contributor
|
@solomon23 can this PR be closed and #74 be used? |
Author
|
yea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #48
if max is less than the min, it'll loop twice. first to the end of the range from min, and than from the low end of the range to max.
I wasn't sure how you were generating the code, so i just modified the later.js directly. not sure if that's correct.