Don't set state to not-ready if the ready prop is true#81
Open
michaelmulley wants to merge 1 commit intobuildo:masterfrom
Open
Don't set state to not-ready if the ready prop is true#81michaelmulley wants to merge 1 commit intobuildo:masterfrom
michaelmulley wants to merge 1 commit intobuildo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered a bug with the
delayprop which would result in the placeholder showing indefinitely, with{ready: true}in props but{ready: false}in state.I believe the events which lead to this are, when delay is set to n milliseconds, all of the following happen before n milliseconds is up:
readyprop is set to false, a timeout to setreadystate is set and the ID stored inthis.timeoutprops.childrenis changed, causecomponentWillReceivePropsto be called again; this causes another timeout to setreadystate to be created, and the ID stored inthis.timeoutis overwrittenreadyprop is set to true, which sets state to{ready: true}and which also deletes the timeout set in step 2 (but, crucially, not the timeout set in step 1){ready: false}The pull request is one approach among many to fix this. You could also clear any existing timeout in
this.timeoutbefore setting a new one, or change the render method toThanks!