Create the property holdPlaceholder to keep the placeholder for some …#55
Open
fabio-paiva-sp wants to merge 2 commits intobuildo:masterfrom
Open
Create the property holdPlaceholder to keep the placeholder for some …#55fabio-paiva-sp wants to merge 2 commits intobuildo:masterfrom
fabio-paiva-sp wants to merge 2 commits intobuildo:masterfrom
Conversation
FrancescoCioria
suggested changes
Nov 23, 2017
| componentWillReceiveProps(nextProps) { | ||
| if (!this.props.firstLaunchOnly && this.state.ready && !nextProps.ready) { | ||
| this.setNotReady(); | ||
| if (!this.props.firstLaunchOnly && !nextProps.ready) { |
Contributor
There was a problem hiding this comment.
I find this new code over complicated and difficult to read...
Why didn't you use the two functions setReady and setNotReady already implemented?
we already have a state variable called ready to decide if we should render the placeholder or the content => I don't see the need of the new this.state.holdPlaceholder variable
|
|
||
| componentWillMount() { | ||
| if (this.props.holdPlaceholder > 0) { | ||
| this.holdPlaceholderTimeout = setTimeout(() => this.setState({ holdPlaceholder: false }), this.props.holdPlaceholder); |
Contributor
There was a problem hiding this comment.
why are you always setting a timeout? shouldn't it be added only if this.state.ready (which is initialized to this.props.ready) is true?
|
|
||
| render() { | ||
| return this.state.ready ? this.props.children : this.getFiller(); | ||
| const { ready, holdPlaceholder } = this.state; |
Contributor
There was a problem hiding this comment.
we already have ready, can't see the need for another variable that does the same thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opposite from
delay, to keep the placeholder for some milliseconds even after the content is readySee #54