Gracefully handle failure from suite API calls#10
Open
malclocke wants to merge 1 commit into
Open
Conversation
When GET /suites/:id or POST /suites/create_from_pipeline return an unexpected status, emit a warning and let the job proceed rather than exiting with 1. Tests and env vars are still configured; only result upload may be affected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nprizal
approved these changes
Jun 4, 2026
Contributor
nprizal
left a comment
nprizal
left a comment
There was a problem hiding this comment.
Thid looks good! However, if the suite creation fails, the OIDC token won’t authenticate because the suite doesn’t exist and bktec doesn’t handle that exception gracefully. We might need to update the bktec / test plan API to manage this situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TE-6046.
GET /suites/:idreturns an unexpected status (not 200/401/404), emit a warning and continue rather than exiting with 1POST /suites/create_from_pipelinefails (not 200/201), emit a warning and continue rather than exiting with 1get_suite/create_suite), then add a warning that the job is proceedingTest plan
successand check for theWarning:stringmake test)🤖 Generated with Claude Code