Conversation
|
Hey! That's awesome. I think I like the rounded one most as well. I think that having a |
|
I just realised that the bb-browser favicon is also a good alternative, maybe even better. |
|
I'm happy with this update now. Will be integrated in buildbarn/bb-browser#46. |
|
Considering that we likely want to use this all over the place (pkg/otel, bb-scheduler, bb-browser, ...), what are your thoughts on just having a pkg/logo in this repo that uses |
|
Nice idea, Ed! Updated the commit accordingly. |
| var faviconSvg []byte | ||
|
|
||
| // FaviconSvg holds the Buildbarn logo and can be used as favicon in web browsers. | ||
| var FaviconSvg = faviconSvg |
There was a problem hiding this comment.
Out of curiosity, why the indirection? We can't make the go:embed variable public? I think we should also call this FaviconSVG, as in Go they tend to write abbreviations like HTTP, XML, etc. in all caps.
I tried but failed to encode the favicon in the otel test. What's the best way forward? |
Supplying two logos, one with rounded ends on the lines but then also, unfortunately, manually edited after Drawio export.
I like the one with rounded line caps best but feel free to choose the one you prefer. Where shall it be integrated into the docs? Should there be a
bb-docsfor GitHub pages or should it be put inbb-deployments?