[Harmony] Bug 2005381: Clean up docker configs, run tests locally easier#151
Merged
[Harmony] Bug 2005381: Clean up docker configs, run tests locally easier#151
Conversation
dannycolin
reviewed
Dec 16, 2025
dannycolin
previously approved these changes
Dec 17, 2025
dannycolin
left a comment
There was a problem hiding this comment.
It works as expected.
As a follow-up bug, I'd suggest running shellcheck and aligning the code style either on POSIX sh or Bash instead of having a mixed style.
Member
Author
|
Note that the 6 pending checks are pending because they're listed as required for the branch and they don't exist to run them anymore because I renamed them. I can't fix it until this PR lands though, so we'll have to override the test pass requirement to land this, and then I can go fix it. |
dannycolin
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
sh docker/run-tests-in-docker.shwhich lets you pick a test to run and runs it locally.Additional info