Skip to content

Add CI workflow#121

Merged
stefanvanburen merged 3 commits intomainfrom
svanburen/ci
Apr 10, 2026
Merged

Add CI workflow#121
stefanvanburen merged 3 commits intomainfrom
svanburen/ci

Conversation

@stefanvanburen
Copy link
Copy Markdown
Member

I noticed this repository has no CI workflow (just Vercel preview deploys). This adds a simple CI workflow to confirm the build works and formatting hasn't changed, based on the one in connectrpc.com.

Ref: https://github.com/connectrpc/connectrpc.com/blob/main/.github/workflows/ci.yaml

I noticed this repository has no CI workflow (just Vercel preview
deploys). This adds a simple CI workflow to confirm the build works and
formatting hasn't changed, based on the one in connectrpc.com.

Ref: https://github.com/connectrpc/connectrpc.com/blob/main/.github/workflows/ci.yaml
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
protobuf-com Ready Ready Preview, Comment Apr 10, 2026 2:39pm

Request Review

Comment thread .nvmrc
@@ -0,0 +1 @@
v24.14.0
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to connectrpc.com; see connectrpc/connectrpc.com#327 (comment)

Copy link
Copy Markdown
Contributor

@emcfarlane emcfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

These don't affect anything from a building perspective, just
DX. (Docusaurus hasn't addressed the baseUrl thing yet; in
connectrpc.com I didn't upgrade TypeScript to 6.0, but don't feel the
need to downgrade here.)
@stefanvanburen stefanvanburen merged commit d695138 into main Apr 10, 2026
4 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/ci branch April 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants