Fix edge case in LSP symbol doc hover #4310
Merged
+56
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Jan 30, 2026
|
|
||
| import "google/protobuf/cpp_features.proto"; // unused import | ||
|
|
||
| message TestTopLevel { |
Contributor
There was a problem hiding this comment.
We should also handle:
import "google/protobuf/cpp_features.proto"; // unused import
message TestTopLevel {}
I think we need the comment handling to be aware that it is on it's own newline.
Member
Author
There was a problem hiding this comment.
good call. let me make sure we handle that.
emcfarlane
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added testcase; we don't want the trailing comment on the import to be included as a doc comment for the message without a comment.