[DIP] Add initial documents for image equivalence testing.#65
Open
taiqzheng wants to merge 3 commits intobuddy-compiler:mainfrom
Open
[DIP] Add initial documents for image equivalence testing.#65taiqzheng wants to merge 3 commits intobuddy-compiler:mainfrom
taiqzheng wants to merge 3 commits intobuddy-compiler:mainfrom
Conversation
meshtag
suggested changes
Jun 12, 2023
Member
meshtag
left a comment
meshtag
left a comment
There was a problem hiding this comment.
Thanks for your work on this!
Just some minor comments and then this is LGTM :)
| ``` | ||
| $ pip install pillow | ||
| $ pip install numpy | ||
| $ pip install sys |
Member
There was a problem hiding this comment.
Can you put this in a requirements.txt? Perhaps name it requirements-optional.txt?
Contributor
Author
There was a problem hiding this comment.
Correted with pip install -r requirements.txt
| img1_dim = len(np.array(img1).shape) | ||
| img2_dim = len(np.array(img2).shape) | ||
| if img1_dim != img2_dim: | ||
| print("Please provide images of the same type. Currently, one is a grayscale image and the other is a color image.") |
Member
There was a problem hiding this comment.
It might not always be the case when the mismatched images are grayscale and color (one could be RGB while the other could be RGBA or any other no. of channels?)
Contributor
Author
There was a problem hiding this comment.
Only the first sentence remained now. The RGB and RGBA or other channels is a problem, but im not sure what to write here.
taiqzheng
force-pushed
the
compareImg_dev
branch
from
6c1d11b to
cad1d1e
Compare
EllisLambda
pushed a commit
to EllisLambda/buddy-benchmark
that referenced
this pull request
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add README.md for comfigure virtual environment.
After configure venv, please run the code below: