feat: Add feedback command and lessons.md integration for continuous improvement

README.md

@@ -267,13 +267,23 @@ Additional commands for enhanced quality and validation:
 | `/speckit.clarify`   | Clarify underspecified areas (recommended before `/speckit.plan`; formerly `/quizme`)                                                |
 | `/speckit.analyze`   | Cross-artifact consistency & coverage analysis (run after `/speckit.tasks`, before `/speckit.implement`)                             |
 | `/speckit.checklist` | Generate custom quality checklists that validate requirements completeness, clarity, and consistency (like "unit tests for English") |
+| `/speckit.feedback`  | Extract and store lessons learned from PR review comments for future reference                                                       |
 
 ### Environment Variables
 
 | Variable          | Description                                                                                                                                                                                                                                                                                            |
 | ----------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
 | `SPECIFY_FEATURE` | Override feature detection for non-Git repositories. Set to the feature directory name (e.g., `001-photo-albums`) to work on a specific feature when not using Git branches.<br/>\*\*Must be set in the context of the agent you're working with prior to using `/speckit.plan` or follow-up commands. |
 
+### Lessons Learned
+
+Spec-kit implements a continuous improvement system that captures lessons from PR reviews and applies them to future development work. The `/speckit.feedback` command extracts insights from code review comments and stores them in two places:
+
+- **`memory/lessons.md`** - Central lessons database organized by category (architecture, code-quality, testing, security, performance, documentation)
+- **`memory/feedback/pr-<number>-lessons.md`** - Per-PR detailed feedback summaries that preserve the full context of each review
+
+When you run `/speckit.specify`, `/speckit.plan`, or `/speckit.implement`, these commands automatically load relevant lessons from the central database for their phase and apply them proactively. This creates a compounding knowledge effect where your team's collective wisdom from past reviews continuously improves future implementations, helping avoid repeated mistakes and reinforcing best practices without manual intervention.
+
 ## 📚 Core Philosophy
 
 Spec-Driven Development is a structured process that emphasizes:
@@ -401,7 +411,7 @@ The first step should be establishing your project's governing principles using
 /speckit.constitution Create principles focused on code quality, testing standards, user experience consistency, and performance requirements. Include governance for how these principles should guide technical decisions and implementation choices.
 ```
 
-This step creates or updates the `.specify/memory/constitution.md` file with your project's foundational guidelines that the AI agent will reference during specification, planning, and implementation phases.
+This step creates or updates the `memory/constitution.md` file with your project's foundational guidelines that the AI agent will reference during specification, planning, and implementation phases.
 
 ### **STEP 2:** Create project specifications
 
@@ -431,6 +441,11 @@ see yours. You can edit any comments that you make, but you can't edit comments
 delete any comments that you made, but you can't delete comments anybody else made.
 ```
 
+You can mention a number of issue in your description and it will be used to generate the branch number, such as
+```text
+For GH issue #123, Develop BugZapper, a new fuzzy test framework".
+```
+
 After this prompt is entered, you should see Claude Code kick off the planning and spec drafting process. Claude Code will also trigger some of the built-in scripts to set up the repository.
 
 Once this step is completed, you should have a new branch created (e.g., `001-create-taskify`), as well as a new specification in the `specs/001-create-taskify` directory.

scripts/bash/fetch-pr-feedback.sh

@@ -0,0 +1,220 @@
+#!/usr/bin/env bash
+#
+# fetch-pr-feedback.sh - Extract PR data for the speckit.feedback agent
+#
+# Usage:
+#   ./fetch-pr-feedback.sh <pr_number>
+#   ./fetch-pr-feedback.sh --find-current  # Find open PR for current branch (preferred)
+#   ./fetch-pr-feedback.sh --find-recent   # Find most recently merged PR
+#
+# Output: JSON with PR metadata, review comments, and discussion comments
+#
+
+set -euo pipefail
+
+# Colors for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m' # No Color
+
+error() {
+    echo -e "${RED}ERROR: $1${NC}" >&2
+    exit 1
+}
+
+warn() {
+    echo -e "${YELLOW}WARNING: $1${NC}" >&2
+}
+
+info() {
+    echo -e "${GREEN}$1${NC}" >&2
+}
+
+# Check for gh CLI
+command -v gh >/dev/null 2>&1 || error "GitHub CLI (gh) is required but not installed."
+
+# Check for jq
+command -v jq >/dev/null 2>&1 || error "jq is required but not installed. Install with: brew install jq"
+
+# Verify authentication
+gh auth status >/dev/null 2>&1 || error "Not authenticated with GitHub. Run 'gh auth login' first."
+
+# Get repository info
+get_repo_info() {
+    gh repo view --json owner,name -q '"\(.owner.login)/\(.name)"' 2>/dev/null || error "Not in a GitHub repository."
+}
+
+# Find most recently merged PR for current branch
+find_recent_merged_pr() {
+    local current_branch
+    current_branch=$(git rev-parse --abbrev-ref HEAD 2>/dev/null) || error "Not in a git repository."
+
+    # First try to find a merged PR for the current branch
+    local pr_number
+    pr_number=$(gh pr list --state merged --head "$current_branch" --json number -q '.[0].number' 2>/dev/null)
+
+    if [[ -z "$pr_number" || "$pr_number" == "null" ]]; then
+        # Fallback: get the most recently merged PR in the repo
+        pr_number=$(gh pr list --state merged --json number,mergedAt --limit 10 -q 'sort_by(.mergedAt) | reverse | .[0].number' 2>/dev/null)
+    fi
+
+    if [[ -z "$pr_number" || "$pr_number" == "null" ]]; then
+        error "No merged PRs found for branch '$current_branch' or in recent history."
+    fi
+
+    echo "$pr_number"
+}
+
+# Find open PR for current branch (preferred for pre-merge workflow)
+find_current_pr() {
+    local current_branch
+    current_branch=$(git rev-parse --abbrev-ref HEAD 2>/dev/null) || error "Not in a git repository."
+
+    # First try to find an open PR for the current branch
+    local pr_number
+    pr_number=$(gh pr list --state open --head "$current_branch" --json number -q '.[0].number' 2>/dev/null)
+
+    if [[ -n "$pr_number" && "$pr_number" != "null" ]]; then
+        echo "$pr_number"
+        return
+    fi
+
+    # Fallback: try to find a merged PR for the current branch
+    pr_number=$(gh pr list --state merged --head "$current_branch" --json number -q '.[0].number' 2>/dev/null)
+
+    if [[ -n "$pr_number" && "$pr_number" != "null" ]]; then
+        warn "No open PR found, using most recently merged PR for this branch."
+        echo "$pr_number"
+        return
+    fi
+
+    error "No open or merged PRs found for branch '$current_branch'."
+}
+
+# Fetch PR basic info
+fetch_pr_info() {
+    local pr_number=$1
+    gh pr view "$pr_number" --json number,title,body,state,mergedAt,headRefName,url,author 2>/dev/null || error "Failed to fetch PR #$pr_number"
+}
+
+# Fetch review comments via GraphQL
+fetch_review_comments() {
+    local pr_number=$1
+    local repo_info
+    repo_info=$(get_repo_info)
+    local owner="${repo_info%/*}"
+    local repo="${repo_info#*/}"
+
+    local result
+    result=$(gh api graphql -f query='
+        query($owner: String!, $repo: String!, $number: Int!) {
+            repository(owner: $owner, name: $repo) {
+                pullRequest(number: $number) {
+                    reviews(first: 100) {
+                        nodes {
+                            body
+                            author { login }
+                            state
+                            submittedAt
+                            comments(first: 50) {
+                                nodes {
+                                    body
+                                    path
+                                    line
+                                    author { login }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    ' -f owner="$owner" -f repo="$repo" -F number="$pr_number" 2>/dev/null)
+
+    if [[ -z "$result" ]]; then
+        warn "Failed to fetch review comments for PR #$pr_number"
+        echo "null"
+    else
+        echo "$result"
+    fi
+}
+
+# Fetch PR discussion comments
+fetch_discussion_comments() {
+    local pr_number=$1
+    local result
+    result=$(gh pr view "$pr_number" --json comments 2>/dev/null)
+
+    if [[ -z "$result" ]]; then
+        warn "Failed to fetch discussion comments for PR #$pr_number"
+        echo "null"
+    else
+        echo "$result"
+    fi
+}
+
+# Main function to fetch all PR feedback data
+fetch_all_feedback() {
+    local pr_number=$1
+
+    info "Fetching PR #$pr_number data..."
+
+    local pr_info
+    local review_comments
+    local discussion_comments
+
+    pr_info=$(fetch_pr_info "$pr_number")
+    review_comments=$(fetch_review_comments "$pr_number")
+    discussion_comments=$(fetch_discussion_comments "$pr_number")
+
+    # Normalize empty strings to "null" for jq
+    [[ -z "$review_comments" || "$review_comments" == "null" ]] && review_comments="null"
+    [[ -z "$discussion_comments" || "$discussion_comments" == "null" ]] && discussion_comments="null"
+
+    # Combine all data into a single JSON object
+    jq -n \
+        --argjson pr_info "$pr_info" \
+        --argjson review_comments "$review_comments" \
+        --argjson discussion_comments "$discussion_comments" \
+        '{
+            pr: $pr_info,
+            reviews: $review_comments,
+            discussion: $discussion_comments
+        }'
+}
+
+# Parse arguments
+case "${1:-}" in
+    --find-current)
+        pr_number=$(find_current_pr)
+        info "Found PR for current branch: #$pr_number"
+        fetch_all_feedback "$pr_number"
+        ;;
+    --find-recent)
+        pr_number=$(find_recent_merged_pr)
+        info "Found most recent merged PR: #$pr_number"
+        fetch_all_feedback "$pr_number"
+        ;;
+    --help|-h)
+        echo "Usage: $0 <pr_number> | --find-current | --find-recent"
+        echo ""
+        echo "Arguments:"
+        echo "  <pr_number>     Specific PR number to fetch feedback from"
+        echo "  --find-current  Find and fetch the open PR for current branch (falls back to merged)"
+        echo "  --find-recent   Find and fetch the most recently merged PR for current branch"
+        echo ""
+        echo "Output: JSON with PR metadata, review comments, and discussion comments"
+        exit 0
+        ;;
+    "")
+        error "No PR number provided. Use '$0 <pr_number>', '$0 --find-current', or '$0 --find-recent'"
+        ;;
+    *)
+        if [[ "$1" =~ ^[0-9]+$ ]]; then
+            fetch_all_feedback "$1"
+        else
+            error "Invalid PR number: $1"
+        fi
+        ;;
+esac