Make list/object parse results immutable and add tests#87
Merged
leoafarias merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes ListSchema and ObjectSchema return unmodifiable collections before constraints/refinements are applied.
It adds parse_result_immutability_test.dart to verify immutability across object/list/discriminated schemas, nested validated structures, additional-properties behavior, and safeParse flows.
It also includes small formatting-only updates in list_schema_extensions_test.dart for long expect lines.
Validation run: dart test in packages/ack (full suite).