Skip to content

Install Node dependencies before CI code generation#8

Closed
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/critical-bug-inspection-31d7
Closed

Install Node dependencies before CI code generation#8
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/critical-bug-inspection-31d7

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 7, 2026

Bug and impact

The CI workflow moved Node setup before just code-gen, but still ran TypeScript client generation before installing npm dependencies. In a clean GitHub Actions runner, npm run generate:client cannot find the workspace-local openapi-ts binary, causing the build workflow to fail before build/test coverage runs.

Root cause

just code-gen includes generate-ts-client, which invokes npm run generate:client. actions/setup-node only installs Node and configures cache; it does not install packages from package-lock.json.

Fix

Add npm ci immediately after Node setup and before just code-gen, so the locked workspace dependencies are installed when code generation runs.

Validation

  • Reproduced the clean-checkout failure: npm run generate:client exited 127 with openapi-ts: not found before installing dependencies.
  • Ran npm ci and confirmed node_modules/.bin/openapi-ts is installed (openapi-ts --version => 0.93.1).
  • Ran npm run generate:client successfully after dependency installation using generated OpenAPI output.
  • Attempted the full equivalent codegen path; local runner lacks the C++ standard library needed by rdkafka-sys, so that environment-specific compile step failed before completion.
Open in Web View Automation 

Co-authored-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
@bruno-medeiros bruno-medeiros deleted the cursor/critical-bug-inspection-31d7 branch May 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants