Install Node dependencies before CI code generation#8
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The CI workflow moved Node setup before
just code-gen, but still ran TypeScript client generation before installing npm dependencies. In a clean GitHub Actions runner,npm run generate:clientcannot find the workspace-localopenapi-tsbinary, causing the build workflow to fail before build/test coverage runs.Root cause
just code-genincludesgenerate-ts-client, which invokesnpm run generate:client.actions/setup-nodeonly installs Node and configures cache; it does not install packages frompackage-lock.json.Fix
Add
npm ciimmediately after Node setup and beforejust code-gen, so the locked workspace dependencies are installed when code generation runs.Validation
npm run generate:clientexited 127 withopenapi-ts: not foundbefore installing dependencies.npm ciand confirmednode_modules/.bin/openapi-tsis installed (openapi-ts --version=>0.93.1).npm run generate:clientsuccessfully after dependency installation using generated OpenAPI output.rdkafka-sys, so that environment-specific compile step failed before completion.