Skip to content

Fix CI Node install before code generation#7

Closed
cursor[bot] wants to merge 2 commits into
masterfrom
cursor/critical-bug-inspection-6228
Closed

Fix CI Node install before code generation#7
cursor[bot] wants to merge 2 commits into
masterfrom
cursor/critical-bug-inspection-6228

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 7, 2026

Bug and impact

Master CI fails during just code-gen because generate-ts-client invokes openapi-ts before any Node dependencies are installed. This blocks the Build workflow on clean GitHub runners.

Root cause

The workflow moved actions/setup-node after code generation and never ran npm ci before npm run generate:client, so the workspace binary openapi-ts is absent.

Fix

Set up Node from .nvmrc and run npm ci before just code-gen, then reuse that Node setup for the later frontend build.

Validation

  • Confirmed the failed master run ends with sh: 1: openapi-ts: not found in Generate OpenAPI code.
  • Reproduced locally with no node_modules: npm run generate:client fails with openapi-ts: not found.
  • Verified after npm ci: CXX=g++ ./catalog-svc/generate-openapi.sh && npm run generate:client succeeds and leaves the working tree clean.
Open in Web View Automation 

cursoragent and others added 2 commits May 7, 2026 16:12
Co-authored-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
Co-authored-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
@bruno-medeiros bruno-medeiros deleted the cursor/critical-bug-inspection-6228 branch May 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants