Open
Conversation
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic found 1 issue across 7 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| window_size=ViewportSize(width=window_w, height=window_h), | ||
| traces_dir=None, | ||
| record_video_dir=None, | ||
| downloads_path="./tmp/downloads" |
Contributor
There was a problem hiding this comment.
The disable_security setting retrieved earlier from browser_config is ignored, so the BrowserProfile is always created with its default security settings. This prevents callers from actually disabling browser security headers as intended.
Suggested change
| downloads_path="./tmp/downloads" | |
| downloads_path="./tmp/downloads", disable_security=disable_security |
Collaborator
|
why downgrade? |
Author
|
Browser-use 0.2.7 is the latest browser use version (https://github.com/browser-use/browser-use/releases/tag/0.2.7). The new BU Version improved a lot of things like for example scrolling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade to browser-use==0.2.7
Replaced old browser_use.browser.Browser API with new, simplified BrowserProfile and BrowserSession API.
Removed 'save playwright script' feature because of removal in browser-use.
Summary by cubic
Upgraded to browser-use 0.2.7, replacing the old Browser API with the new BrowserProfile and BrowserSession APIs. Removed the "save playwright script" feature due to its removal upstream.