Add crbr.podatki.gov.pl domain skill#410
Conversation
…current entry, UI traps
✅ Skill review passedReviewed 1 file(s) — no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f372f47f5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```python | ||
| import json | ||
| r = http_post( |
There was a problem hiding this comment.
Replace undefined http_post helper
This skill tells agents to call http_post, but the harness only provides http_get in helpers.py and no other domain skill defines http_post (checked with rg "http_post"). A future agent following this example will hit NameError before reaching the documented API; the snippet should either show a local urllib.request.Request(..., method="POST") pattern or add/use an actual helper.
Useful? React with 👍 / 👎.
| "dataOd": "2026-06-06", # date range of register entries | ||
| "dataDo": "2026-06-06", |
There was a problem hiding this comment.
Avoid hard-coding the current-date search window
The example hard-codes 2026-06-06 while the surrounding text says this should be today to fetch the current entry. Once agents reuse the skill after June 6, 2026, this payload will request the register state for that old date rather than the current default portal search, producing stale beneficial-owner results; use a computed date.today().isoformat() value instead.
Useful? React with 👍 / 👎.
Field-tested knowledge from automating Poland's CRBR (beneficial owners register):
POST /adcrbr/api/wyszukajSpolkeworks from plain HTTP withreCaptchaToken: "0"— no browser needed. Payload shape + date-range semantics documented (current entry vs full history, oldest-first).obywatelstwois an array of{kodKraju, nazwa}, PESEL null for foreigners (DOB set instead), control description inuprWlasPosrednie..click()works); headless-Chromium XHR fails with status 0 while curl succeeds; the search bundle is lazy-loaded so the endpoint isn't greppable frommain.*.js.🤖 Generated with Claude Code
Summary by cubic
Adds a new domain skill for Poland’s CRBR search at crbr.podatki.gov.pl, documenting a private search API and key field semantics. It enables direct HTTP searches and explains how to fetch current entries or full history.
POST /adcrbr/api/wyszukajSpolkeusage without a browser (reCaptchaToken: "0") and date range rules for current vs full history (oldest-first).obywatelstwoas an array,peselnull for foreigners withdataUrodzeniaset, and control info inuprWlasPosrednie; includes empty-result (200) and Spring-style 404 behaviors..click()), headless Chromium XHR can fail while curl works, and the lazy-loaded search bundle hides the endpoint.Written for commit f372f47. Summary will update on new commits.