Chris follett

[follettocean]

I built some code to grab the half degree fields from both geo and Darwin and do the OC-CCI water class estimate. Currently, the code does the additional Rirr to Rrs correction on the DARWIN Data. The 'tryJackson' is the important one. I am still new to this GitHub thing so sorry if this is a giant fail. The code is in Julia.

[gaelforget]

Reviewing this now. Some quick thoughts from just reading the above message

• Rirr to Rrs may be more of a conversion that a correction
• 'tryJackson' seems a bit odd (not sure if it's in the code

[gaelforget]

Will post comments on PR content below as I go:

• instead of creating a new RrsCorrection.jl why not just use the readily packaged version in OceanColorData.jl which I mentioned before?
• Same thing for duplicating the fcm, getJackson, M09.jl, etc functions. As much as possible we want to avoid having to maintain multiple versions moving forward -- more generally duplicating code tends to create all sorts of problems and confusion downstream.
• before merging it would probably be good to remove information about your hard drive folders (C:\Users\folle\Dropbox (MIT)... etc)
• could you better document how HalfDegree.nc is generated? Even if it were just (?) 1. download from this ftp & 2. rename to HalfDegree.nc or something like that. I see references to file named DARWINGrid0.5.nc, etc in one README.md but that does not match what's listed in the main README.md (gridded_geospatial_montly_clim_360_720_ver_0_2.nc etc) so I am rather confused.
• not sure about MakeGridDarwin2.jl as a name -- the function does not seem to actually make a grid or relying on Darwin2; maybe 2 is a reference to an earlier version on your laptop or something like that?

Overall I feel that this should not require so much new / duplicated code but maybe I am missing something obvious here.

[gaelforget]

@follettocean

How are things going with this?

Once you are done with the suggested changes, please let me know it's ready for another review. Would be nice to merge this PR soon, so we can add the interpolation from native grid etc, and make this a one step process.

[gaelforget]

@follettocean

How are things going with this?

Once you are done with the suggested changes, please let me know it's ready for another review. Would be nice to merge this PR soon, so we can add the interpolation from native grid etc, and make this a one step process.

Hi @follettocean

When do you plan to revise this?

In the mean time I outline the single step pipeline @ https://github.com/gaelforget/MarineEcosystemNotebooks/blob/master/OceanColor/04-ClassificationTestbed.ipynb

This should include all you need to go from the dropbox content to the csv we want for this