Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds AWS Athena (via the
dbt-athenaadapter) as a supported data warehouse for the dbt_artifacts package. Athena is built on the Trino engine, so the implementation closely mirrors the existing Trino adapter support.Update type - breaking / non-breaking
What does this solve?
Closes #399 and closes #439. Adds Athena support as a new data warehouse target, including Iceberg table format support — addressing both feature requests from the community.
Description
Adds AWS Athena (via the
dbt-athenaadapter) as a supported data warehouse for the dbt_artifacts package.Athena is built on the Trino engine, so the implementation closely mirrors the existing Trino adapter support.
Changes
New Athena dispatch macros
athena__type_array(),athena__type_numeric(),athena__str_left(),athena__insert_into_metadata_table()athena__get_*_dml_sql()for all 11 datasets (invocations, models, model_executions, exposures, sources, seeds, seed_executions, tests, test_executions, snapshots, snapshot_executions)Configuration
dbt_project.yml: Iceberg file_format for Athena, persist_docs exclusiontox.ini: Athena integration test environment, AWS credential passenvprofiles.yml: Athena target profile with work_group, S3 dirs, regionsafe_cast.sql: Athena type mappingsexample-env.sh: Athena environment variable placeholdersREADME.md: Athena listed in supported data warehousesTest fixture adjustments
incremental.sql: Cast string literals todbt.type_string()for Athena varchar compatibilitypartitioned_byconfig)Testing
Integration tests run against real AWS Athena (engine v3):
Outstanding questions
None at this time.
What databases have you tested with?
Checklist