support pull to sync, save sort order and double tap to change sort direction in task lists#18
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds task-list UX improvements on Android by introducing pull-to-sync, persisting task sort preferences (order + direction), and surfacing sync status in the UI.
Changes:
- Persist sort order and sort direction in settings, and apply them in
TaskViewModel. - Add pull-to-refresh style sync trigger to the task list and display transient sync status text.
- Update unit tests/mocks and add an instrumentation test for the task list pull gesture.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| android/config/detekt/detekt.yml | Relaxes TooManyFunctions thresholds for classes/interfaces. |
| android/app/src/test/kotlin/com/brokenpip3/fatto/WaitingTasksFilterTest.kt | Updates repository mocks to include new sort settings flows. |
| android/app/src/test/kotlin/com/brokenpip3/fatto/TaskSortTest.kt | Updates repository mocks to include new sort settings flows. |
| android/app/src/test/kotlin/com/brokenpip3/fatto/BlockedTasksFilterTest.kt | Updates repository mocks to include new sort settings flows. |
| android/app/src/main/kotlin/com/brokenpip3/fatto/vm/TaskViewModel.kt | Adds sort direction + persistence hooks; adds sync cooldown and sync status message state. |
| android/app/src/main/kotlin/com/brokenpip3/fatto/ui/tasklist/TaskListScreen.kt | Implements nested-scroll pull-to-sync trigger; shows sort direction icon and sync status message. |
| android/app/src/main/kotlin/com/brokenpip3/fatto/data/TaskRepository.kt | Exposes sort order/direction state + setter pass-throughs to settings. |
| android/app/src/main/kotlin/com/brokenpip3/fatto/data/SettingsRepository.kt | Stores sort order/direction in encrypted shared preferences and exposes them as StateFlows. |
| android/app/src/androidTest/kotlin/com/brokenpip3/fatto/ui/tasklist/PullToRefreshSyncTest.kt | Adds a Compose UI test covering a pull-down gesture on the task list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.