feat(remove-bash): drop bash fallback, fail loudly on unsupported triples (#19)#33
Merged
nmccready merged 1 commit intoMay 19, 2026
Conversation
…ples (#19) - Delete src/sh/sync-agents.sh — bash implementation removed - bin/sync-agents.js: remove fallback branch; unsupported triples now exit 1 with a clear message pointing to go install / brew / GitHub Releases - package.json: drop lint (shellcheck), test:sh, concurrently devDep; test script delegates to make test; files array no longer includes src/**/* - Makefile test target: remove SYNC_AGENTS_BIN=bin/sync-agents prefix - test/sync-agents.bats: resolve Go binary by default (bin/sync-agents) instead of the bash script; SYNC_AGENTS_BIN override kept for CI flexibility Closes #19 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #32 (install channels) — merge that first, then this.
src/sh/sync-agents.sh— bash implementation gonebin/sync-agents.js: removedfallbackShellScript()branch; unsupported triples now exit 1 with an actionable error pointing togo install,brew, and GitHub Releasespackage.json: removedlint(shellcheck),test:sh,concurrentlydevDep;testdelegates tomake test;filesarray no longer shipssrc/**/*Makefile:testtarget no longer setsSYNC_AGENTS_BIN=bin/sync-agents(bats defaults to it directly now)test/sync-agents.bats: resolver points atbin/sync-agents(Go binary) instead of the bash script;SYNC_AGENTS_BINenv override kept for CI flexibilityTest plan
go build ./...passes (verified locally)make build && npx bats test/sync-agents.batsruns against the Go binarynpm testruns viamake testwithout shellcheck or concurrentlynpx @brickhouse-tech/sync-agentsprints the install-channel error and exits 1Closes #19
🤖 Generated with Claude Code