chore: normalize test labels to the topic: behavior convention#365
Merged
Conversation
Convert the few tests using the compiler's fully-qualified module.path.symbol:behavior label style to the shorter topic: behavior form used throughout mach-std. Only label strings change; test bodies and other code are untouched. Closes #364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes the handful of tests still using the compiler's fully-qualified
module.path.symbol:behaviorlabel style to the shorter"topic: behavior"convention used throughout mach-std.Topics chosen to match each module's existing labels:
std.process.exec.spawn_redirected:pipes_child_stdoutexec: spawn_redirected pipes child stdoutstd.process.exec.wait_any:reaps_each_child_onceexec: wait_any reaps each child oncestd.process.exec.wait_any:errs_with_no_childrenexec: wait_any errs with no childrenstd.system.os.cpu_count:at_least_oneos: cpu_count at least onelog functions: nil message does not crashlog: nil message does not crashThe
exec:andos:topics mirror how neighboring tests abbreviate their module to its leaf name;log:tightens the two-wordlog functionstopic to match the single-tokenset_level:topic used by the other log tests.Only label strings change. Test bodies and all other code are untouched, and labels are not referenced by code, so renaming is safe.
mach build .andmach test .pass identically before and after (620 passed, 0 failed, 620 total).Closes #364