Conversation
every kernel32 import under src/system/os/windows/ and the windows runtime entrypoint was unattributed, reaching the PE writer as DYNLIB_ANY and relying on the COFF fallback binding it to dependency 0 (kernel32.dll only when kernel32 sorts first). the first mixed-DLL consumer breaks that implicit ordering contract, mis-binding a whole DLL set and yielding STATUS_ENTRYPOINT_NOT_FOUND at load. pin each ext import with an explicit #[library] decorator naming its providing DLL, removing the ordering dependency. purely additive: correctly-ordered links are unchanged. Closes #334
fix(system/os/windows): pin every ext import to its providing DLL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls dev to main: every windows import explicitly pinned (#334/PR #358) — prerequisite for mach#1800's unattributed-import hard link error.