serverwatch: cap threshold spam with both re-arm grace and cooldown#49
Merged
Conversation
The sustained-drop re-arm alone still lets a population hovering around a threshold re-ping: genuine dips below the threshold (longer than rearm_grace) re-arm the rule, so each re-crossing fires. Re-add the per-rule cooldown gate alongside the re-arm logic. A rule now fires once per upward crossing AND at most once per `cooldown` since its last ping. rearm_grace kills transient map-change re-pings; cooldown caps genuine hovering. - Restore guild `cooldown` setting (default 1800s) and `set cooldown`; the Intervals modal/view show both rearm_grace and cooldown. - ping_state tracks `last_ping` again (lazily defaulted via .get). - Tighten over-explained comments in the threshold/query logic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sustained-drop re-arm alone still lets a population hovering around a threshold re-ping: genuine dips below the threshold (longer than rearm_grace) re-arm the rule, so each re-crossing fires.
Re-add the per-rule cooldown gate alongside the re-arm logic. A rule now fires once per upward crossing AND at most once per
cooldownsince its last ping. rearm_grace kills transient map-change re-pings; cooldown caps genuine hovering.cooldownsetting (default 1800s) andset cooldown; the Intervals modal/view show both rearm_grace and cooldown.last_pingagain (lazily defaulted via .get).