Merged
Conversation
- Introduced EventFilter interface to define filter criteria for profiler events. - Added commands for applying and clearing filters from the webview. - Implemented handleApplyFilters and handleClearFilters methods to manage filter state. - Enhanced event polling to apply filters dynamically, allowing for case-insensitive substring matches. - Added a search bar to the profiler panel for quick event searching, with navigation for previous and next matches. - Updated UI to include filter modal and search bar, improving user experience for managing event data. - Refactored event rendering to support new filtering and searching capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the VS Code extension and the JSON-RPC server, focusing on reliability, initialization order, and cross-language compatibility. The most significant changes are grouped below by theme.
Extension activation reliability and command registration
vscode-extension/package.jsonfromonCommand:lightQueryProfiler.showProfilertoonStartupFinishedto ensure the extension is loaded early and the command handler is reliably registered.activateinvscode-extension/src/extension.tsto register thelightQueryProfiler.showProfilercommand immediately at startup, preventing missed command invocations during async initialization. Added deferred panel opening logic to handle cases where the provider is not yet ready. [1] [2]Logging and diagnostic output
src/LightQueryProfiler.JsonRpc/Program.cs. [1] [2]JSON-RPC server compatibility and serialization
CamelCasePropertyNamesContractResolveron theJsonMessageFormatterand documenting the serialization inProfilerEventDto. [1] [2]JsonRpcServerwithUseSingleObjectParameterDeserialization = true, preventing parameter-matching errors when called from TypeScript clients. [1] [2] [3] [4]Miscellaneous improvements
highlight.jstoLICENSE.md.highlight-vs2015.min.cssstylesheet for syntax highlighting in the extension.These changes collectively improve extension startup reliability, cross-language communication, and maintain compliance with third-party licensing.