Conversation
Use sqlserver.username (instead of nt_username) and remove server_principal_name in the Azure SQL profiler template. Also include InitialCatalog when checking/recording connection uniqueness so connections are distinct per database. Add unit tests for both behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to connection uniqueness logic, Azure SQL Profiler session templates, and the handling of recent connections in the application. The main focus is on ensuring that connections are uniquely identified by server, user, and database, and updating templates and UI logic to reflect the correct fields for Azure SQL versus SQL Server. Comprehensive unit tests are also added to verify these behaviors.
Connection uniqueness improvements:
InitialCatalog(database name) in addition toDataSourceandUserIdwhen determining if a connection is unique, ensuring connections to the same server and user but different databases are treated as distinct.ConnectionUniquenessTeststo thoroughly verify that connection uniqueness is determined by the combination of server, user, and database, including case-insensitive comparisons and various authentication/engine scenarios.Azure SQL Profiler session template updates:
sqlserver.usernameinstead ofsqlserver.nt_usernameand removedsqlserver.server_principal_namefrom the captured actions, ensuring compatibility with Azure SQL auditing requirements.Recent connections UI and data model enhancements:
RecentConnectionsPresenterto store and retrieveEngineTypeandAuthenticationModein the recent connections grid, ensuring these properties are preserved and correctly restored when selecting a recent connection. [1] [2] [3]AuthenticationModeand improved the data table schema to include the new fields.These changes collectively enhance the accuracy and reliability of connection management and profiling in the application.
Resolves: #27