Reject duplicate entries in router builder#142
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aswink
changed the title
Currently the router builder silently drops duplicate entries, solve this by returning an error if the builder sees that. Also explicitly set default format -> provider mappings, and also error if there are duplicate entries in the builder there. Also clean up some override client stuff.
aswink
force-pushed
the
aswin/03-11-avoid_duplicate_entries_in_router_builder
branch
from
32118b8 to
d1eec00
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the router builder silently drops duplicate entries, solve this by
returning an error if the builder sees that. Also explicitly set default format
-> provider mappings, and also error if there are duplicate entries in the
builder there.
Also clean up some override client stuff.