Simplify project context/auth flow for read-only commands + persist project_id#58
Open
Parker Henderson (parkerhendo) wants to merge 4 commits intomainfrom
Open
Simplify project context/auth flow for read-only commands + persist project_id#58Parker Henderson (parkerhendo) wants to merge 4 commits intomainfrom
Parker Henderson (parkerhendo) wants to merge 4 commits intomainfrom
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Contributor
|
happy to try to review (rust is not yet my strong suit), but at a high level this pr could use some tests. i'll come back around today, but let me know if you'd like to proceed without tests Parker Henderson (@parkerhendo) |
Contributor
Author
Olmo Maldonado (@ibolmo) I'll go back through and add some tests for it. |
Contributor
Author
|
Olmo Maldonado (@ibolmo) added some tests for the new paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
project_id exists.