Fix filter_ai_spans bypass for root spans#124
Merged
David Elner (delner) merged 1 commit intobraintrustdata:mainfrom Mar 18, 2026
Merged
Conversation
Remove the unconditional `return true if is_root` check in SpanProcessor#should_forward_span? so that filters (including filter_ai_spans) are applied to root spans as well. This aligns the Ruby SDK behavior with the Python and JS SDKs. Fixes braintrustdata#123
David Elner (delner)
added
enhancement
David Elner (delner)
approved these changes
Mar 18, 2026
Collaborator
David Elner (delner)
left a comment
David Elner (delner)
left a comment
There was a problem hiding this comment.
Looks pretty straightforward to me. Thanks for the contribution! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return true if is_rootinSpanProcessor#should_forward_span?so that configured filters (includingfilter_ai_spans) are applied to root spans