ref(e2e): migrate deno scenarios from smoke to e2e harness#1641
Merged
Abhijeet Prasad (AbhiPrasad) merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
Add `runDenoScenarioDir()` to the e2e scenario harness so Deno tests can run alongside Node/tsx scenarios under the same mock-server infrastructure. Remove the standalone `deno-node` and `deno-browser` smoke scenarios and the legacy `js/smoke/tests/deno/deno.json` config, which are superseded by `e2e/scenarios/deno-node/` and `e2e/scenarios/deno-browser/`. - Refactor `runProcess` to accept an explicit `command` arg so it can spawn arbitrary executables (not just `process.execPath`) - Add `runDenoScenarioDir()` that invokes `deno test --no-check` with the standard harness env vars; defaults entry to `runner.case.ts` - Expose `runDenoScenarioDir` on the `ScenarioHarness` interface and wire it through `withScenarioHarness` - Update `e2e/README.md` and `.agents/skills/e2e-tests/SKILL.md` to document the new helper and Deno-specific conventions - Clean up `js/smoke/README.md` and `js/smoke/shared/README.md` to remove references to the deleted smoke scenarios
Luca Forstner (lforst)
approved these changes
Mar 24, 2026
Member
Luca Forstner (lforst)
left a comment
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
thanks! this moving from smoke to e2e is good 👍
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-refactor-migrate-deno-smoke-to-e2e
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
runDenoScenarioDir()to the e2e scenario harness so Deno tests can run alongside Node/tsx scenarios under the same mock-server infrastructure. Remove the standalonedeno-nodeanddeno-browsersmoke scenarios and the legacyjs/smoke/tests/deno/deno.jsonconfig, which are superseded bye2e/scenarios/deno-node/ande2e/scenarios/deno-browser/.runProcessto accept an explicitcommandarg so it can spawn arbitrary executables (not justprocess.execPath)runDenoScenarioDir()that invokesdeno test --no-checkwith the standard harness env vars; defaults entry torunner.case.tsrunDenoScenarioDiron theScenarioHarnessinterface and wire it throughwithScenarioHarnesse2e/README.mdand.agents/skills/e2e-tests/SKILL.mdto document the new helper and Deno-specific conventionsjs/smoke/README.mdandjs/smoke/shared/README.mdto remove references to the deleted smoke scenarios