Merged
Conversation
Stephen Belanger (Qard)
requested review from
Kevin Gosse (kevingosse) and
Andrew Kent (realark)
Stephen Belanger (Qard)
force-pushed
the
trace-scorers
branch
from
1e8f76a to
aa55f0d
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Kevin Gosse (kevingosse)
requested changes
Mar 22, 2026
Contributor
Kevin Gosse (kevingosse)
left a comment
Kevin Gosse (kevingosse)
left a comment
There was a problem hiding this comment.
Mostly NITs + a couple of important changes.
- IBtqlClient: extend IDisposable - BtqlClient: return [] literal; use .Cast<> instead of explicit cast in Select - Eval: use OfType<> instead of Any(s => s is) - ITracedScorer: rename ScoreAsync -> Score (overload of IScorer.Score) - EvalTrace: add GetThreadAsync tests - Program.cs: use DatasetCase.Of type inference Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Kevin Gosse (kevingosse)
approved these changes
Mar 23, 2026
Contributor
Kevin Gosse (kevingosse)
left a comment
Kevin Gosse (kevingosse)
left a comment
There was a problem hiding this comment.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.