Draft
Conversation
juliamertz
force-pushed
the
feat/nix-oci-buildtools
branch
from
03825b6 to
6207a1e
Compare
juliamertz
force-pushed
the
feat/nix-oci-buildtools
branch
from
6207a1e to
eeacdf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since out the PR branch we were using just built a regular docker image and extracted that into an OCI directory.
I've created a builder which directly outputs an OCI dir, which seems to be working pretty well. There is now also an option to set the image arch, which was previously fixed to the host platform of the builder (oops)
I'll try and add some tests for this later