Draft: fix #714 packaged SDK export validation#716
Draft
andikrueger wants to merge 1 commit intobradygaster:devfrom
Draft
Draft: fix #714 packaged SDK export validation#716andikrueger wants to merge 1 commit intobradygaster:devfrom
andikrueger wants to merge 1 commit intobradygaster:devfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b965c1f to
39e4edc
Compare
Collaborator
|
🔄 Ralph PR status
Implementation complete per author. Draft intentional — author left it for review. Clean and minimal (46 adds / 17 dels). Ready to undraft when author/reviewer decide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #714
Summary
This fixes the packaged CLI/SDK
FSStorageProvidermismatch by making tarball creation rebuild fresh artifacts and by tightening packaging/export coverage.Root cause
FSStorageProvideris exported in source, butnpm packcould reuse staledist/output when package tarballs were created from package directories. That allowed a tarball to carry outdated SDK build artifacts even though the current TypeScript source exportedFSStorageProvidercorrectly.What changed
prepackscripts topackages/squad-sdkandpackages/squad-clisonpm packrebuilds fresh package artifactstest/cli-packaging-smoke.test.tsto rely onnpm packrebuilding the tarballs instead of conditionally reusing existingdist/test/package-exports.test.tsto assertFSStorageProvideris exported from both@bradygaster/squad-sdkand@bradygaster/squad-sdk/storageValidation
npm run build -w packages/squad-sdknpm run build -w packages/squad-clinpx vitest run test\\package-exports.test.ts test\\cli-packaging-smoke.test.tsStatus
Implementation is complete, but I am leaving this PR in draft state for now.