Open
Conversation
(The old version is not downloadable anymore.)
The Dockerfile was moved to the project root for this to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the Docker build and changed the Dockerfile so it uses the code from current checkout instead of cloning the current master branch from Github. Also, as I do not see any advantage in compiling the project during run, the project is already compiled during the image build.
This makes it easy to set up automated builds on the Docker registry hub. You can even set up builds for different branches easily using this technique. @bprodoehl, it would be useful if you could set up such an automated build for this fork so others can easily get the latest binary (and your upcoming 2.1 work?).
In the long run, it would probably make sense for PhantomJS to use Docker and do static Docker builds for their regular releases. This is one of the use cases where Docker really shines.