Skip to content

fix: Increase Sequence number only if it's not a flow.#18

Open
noels wants to merge 1 commit into
bpmnServer:mainfrom
SilexConsulting:change-seq-numbers
Open

fix: Increase Sequence number only if it's not a flow.#18
noels wants to merge 1 commit into
bpmnServer:mainfrom
SilexConsulting:change-seq-numbers

Conversation

@noels

@noels noels commented Dec 29, 2024

Copy link
Copy Markdown

So that sequential numbers display sensible consecutive numbers, only increase seq when the item type is not 'bpmn:SequenceFlow'

seq numbers displayed in the instance details page are non-consecutive because there is no label on 'bpmn:sequenceFlow' elements. This results in 1, 3, 5 being displayed on the labels for items that display the seq number.

image

This change makes the displayed sequence number consecutive:
image

- So that sequential numbers display sensible consecutive numbers,
  only increase seq when the item type is not 'bpmn:SequenceFlow'
@ralphhanna

Copy link
Copy Markdown
Collaborator

I agree. but it will not match, logging information

@noels

noels commented Feb 3, 2025

Copy link
Copy Markdown
Author

I didn't notice the logs. Where can I find that code?

@noels

noels commented Feb 3, 2025

Copy link
Copy Markdown
Author

I guess I could, as an alternative, decorate the flows so that the sequence is the same in the logs.

@ralphhanna

Copy link
Copy Markdown
Collaborator

That would be much better solution, also will show which flow was taken

@noels

noels commented Feb 3, 2025

Copy link
Copy Markdown
Author

I will take a look and try figure out why the decorations on the flows are not showing and come back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants