-
Notifications
You must be signed in to change notification settings - Fork 74
feat: implement raise dispute flow with redirect to dispute review page #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
od-hunter
wants to merge
1
commit into
boundlessfi:main
Choose a base branch
from
od-hunter:feat/raise-dispute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import { NextRequest, NextResponse } from "next/server"; | ||
| import { getCurrentUser } from "@/lib/server-auth"; | ||
| import { graphqlRequest } from "@/lib/server-graphql"; | ||
| import type { AdminDisputeDto, DisputeReasonEnum } from "@/lib/graphql/generated"; | ||
|
|
||
| /** | ||
| * POST /api/disputes | ||
| * | ||
| * Creates a new dispute for a bounty. Forwards the request to the backend | ||
| * GraphQL API once a raiseDispute mutation is available, or to the REST | ||
| * endpoint in the interim. | ||
| * | ||
| * Body: | ||
| * campaignId – ID of the bounty being disputed | ||
| * reason – DisputeReasonEnum value | ||
| * description – Free-text explanation from the filer | ||
| * | ||
| * Returns the created AdminDisputeDto (including its `id`). | ||
| */ | ||
| export async function POST(request: NextRequest) { | ||
| try { | ||
| const user = await getCurrentUser(); | ||
| if (!user) { | ||
| return NextResponse.json({ error: "Unauthorized" }, { status: 401 }); | ||
| } | ||
|
|
||
| const body = await request.json(); | ||
| const { campaignId, reason, description } = body as { | ||
| campaignId?: string; | ||
| reason?: DisputeReasonEnum; | ||
| description?: string; | ||
| }; | ||
|
|
||
| // Input validation | ||
| if (!campaignId || typeof campaignId !== "string") { | ||
| return NextResponse.json( | ||
| { error: "campaignId is required" }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
| if (!reason || typeof reason !== "string") { | ||
| return NextResponse.json( | ||
| { error: "reason is required" }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
| if (!description || typeof description !== "string" || !description.trim()) { | ||
| return NextResponse.json( | ||
| { error: "description is required" }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
|
|
||
| // Forward to the backend REST API | ||
| const backendUrl = process.env.NEXT_PUBLIC_API_URL; | ||
| if (!backendUrl) { | ||
| return NextResponse.json( | ||
| { error: "Backend API URL not configured" }, | ||
| { status: 500 }, | ||
| ); | ||
| } | ||
|
|
||
| const { getAccessToken } = await import("@/lib/auth-utils"); | ||
| const token = await getAccessToken(); | ||
|
|
||
| const backendResponse = await fetch(`${backendUrl}/disputes`, { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| ...(token ? { Authorization: `Bearer ${token}` } : {}), | ||
| }, | ||
| body: JSON.stringify({ | ||
| campaignId, | ||
| reason, | ||
| description, | ||
| }), | ||
| }); | ||
|
Comment on lines
+66
to
+77
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a timeout to the backend proxy call. The route waits on Suggested fix+ const controller = new AbortController();
+ const timeout = setTimeout(() => controller.abort(), 10_000);
+
- const backendResponse = await fetch(`${backendUrl}/disputes`, {
- method: "POST",
- headers: {
- "Content-Type": "application/json",
- ...(token ? { Authorization: `Bearer ${token}` } : {}),
- },
- body: JSON.stringify({
- campaignId,
- reason,
- description,
- }),
- });
+ let backendResponse: Response;
+ try {
+ backendResponse = await fetch(`${backendUrl}/disputes`, {
+ method: "POST",
+ signal: controller.signal,
+ headers: {
+ "Content-Type": "application/json",
+ ...(token ? { Authorization: `Bearer ${token}` } : {}),
+ },
+ body: JSON.stringify({
+ campaignId,
+ reason,
+ description,
+ }),
+ });
+ } finally {
+ clearTimeout(timeout);
+ }🤖 Prompt for AI Agents |
||
|
|
||
| if (!backendResponse.ok) { | ||
| const errorText = await backendResponse.text(); | ||
| console.error("Backend dispute creation failed:", errorText); | ||
| return NextResponse.json( | ||
| { error: "Failed to create dispute" }, | ||
| { status: backendResponse.status }, | ||
| ); | ||
| } | ||
|
|
||
| const dispute = (await backendResponse.json()) as AdminDisputeDto; | ||
| return NextResponse.json(dispute, { status: 201 }); | ||
| } catch (error) { | ||
| console.error("Error creating dispute:", error); | ||
| return NextResponse.json( | ||
| { error: "Failed to create dispute" }, | ||
| { status: 500 }, | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject values outside
DisputeReasonEnum.This currently accepts any string and forwards it downstream, so invalid dispute reasons bypass server-side validation and fail later with a generic backend error.
Suggested fix
🤖 Prompt for AI Agents