refactor: AWS SDK v2로 S3 연동 전환#611
Open
Whale0928 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 요약
S3Client/S3Presigner기반으로 전환ImageUploadService의 presigned PUT URL 생성을 v2S3Presigner.presignPutObject로 변경com.amazonaws.*,aws-java-sdk-s3,libs.aws.s3잔존 제거AmazonS3fake fixture 삭제운영 호환성 보강
ResourceLog CREATED가 저장되도록 생성 로깅을 동기화ResourceVerifierService추가viewUrl과 타 사용자viewUrl은 리뷰 저장 전 4xx로 거부plan/aws-sdk-v2-resource-verify-followup.md5471cb5bdbb3a7cc066534d38131aa049290c835검증
git diff --checkPASSrg -n "com\\.amazonaws|aws-java-sdk-s3|libs\\.aws\\.s3" gradle/libs.versions.toml bottlenote-*결과 0건./gradlew compileJava compileTestJavaPASS./gradlew :bottlenote-product-api:test --tests '*ImageUploadServiceTest' :bottlenote-mono:test --tests '*ImageUploadUnitTest' :bottlenote-product-api:integration_test --tests '*MinioContainerLoadingTest'PASS./gradlew admin_integration_testPASS./gradlew unit_testPASS/verify full수준 검증 PASScompileJava compileTestJavacheck_rule_testunit_testbuild -x test -x asciidoctor --build-cache --parallelintegration_testadmin_integration_testasciidoctor리스크/주의사항
content-type서명 헤더를 포함하므로 클라이언트 PUT 요청 시 동일한 content type 전달이 필요관련 기술 부채