chore(deps): bump xorq>=0.3.25 and adapt tests to API changes#267
Merged
hussainsultan merged 4 commits intoMay 20, 2026
Conversation
Between the previously-pinned 0.3.19 and the new 0.3.25, xorq:
- changed the dispatch returned by ``get_rebuild_dispatch`` to take
``(rebuild_subexpr, remap, to_catalog)`` instead of just
``(rebuild_subexpr)``.
- made tag-op classes frozen with ``parent: Relation``, so
``parent=None`` is no longer constructible (and ``.parent`` cannot
be mutated after construction).
- removed ``xorq.api.read_parquet``; callers use
``deferred_read_parquet``.
- tightened ``xorq.vendor.ibis`` literal inference: scalars
constructed via the foreign top-level ``ibis`` package are
rejected inside a vendored expression.
- added a ``Replayer._rewrite_noop_commits`` step that invokes
``git rebase --onto``, which needs a configured git identity.
Adaptations:
- test_xorq_backends: rename xo.read_parquet -> xo.deferred_read_parquet.
- test_xorq_rebuild: pass ``(rebuild_subexpr, None, None)`` to the
dispatch callable, and replace ``ibis.literal(1)`` inside a reemit
callback with a raw Python scalar so ``mutate`` infers in the
parent's flavor.
- test_xorq_rebuild: add an autouse fixture that sets
``GIT_*_NAME/EMAIL`` env vars so the catalog-replay rebase works
on CI runners with no global git identity.
- serialization/tag_handler.reemit: drop the ``if tag_node.parent is
None`` guard. xorq now declares ``parent`` as a non-null
``Relation``, so the precondition is structurally impossible. Drop
the matching ``test_reemit_raises_on_missing_parent`` test (it
could only fire by mutating a real tag node into an invalid shape,
which xorq's immutability now rejects).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BSL only ever emits HashingTag (both to_tagged and reemit itself use ``hashing_tag``), so the previous "(HashingTag/Tag)" was misleading. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…3.25 # Conflicts: # uv.lock
Same xorq 0.3.20+ API rename already applied in tests; missed this
example call site in the original commit. ``xo.read_parquet`` now falls
through to ``ibis.load_backend("read_parquet")`` which raises
AttributeError, breaking ``make examples``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
xorqfrom>=0.3.19to>=0.3.25and adapts BSL to API changes introduced in that range.Upstream changes between 0.3.19 and 0.3.25:
get_rebuild_dispatchnow returns a callable taking(rebuild_subexpr, remap, to_catalog)instead of just(rebuild_subexpr).parent: Relation(non-null), soparent=Noneis no longer constructible.xorq.api.read_parquetwas removed; callers usedeferred_read_parquet.xorq.vendor.ibisliteral inference now rejects scalars built via the foreign top-levelibispackage inside a vendored expression.Replayer._rewrite_noop_commitsinvokesgit rebase --onto, which needs a configured git identity.Changes
pyproject.toml/uv.lock: bumpxorqto>=0.3.25(andxorq-datafusionto0.2.7transitively).serialization/tag_handler.reemit: drop theif tag_node.parent is Noneguard now that xorq's op definition makes it structurally impossible; update docstring.tests/test_xorq_backends.py:xo.read_parquet→xo.deferred_read_parquet.tests/test_xorq_rebuild.py:(rebuild_subexpr, None, None)to the dispatch callable.ibis.literal(1)inside a reemit callback with a raw Python scalar somutateinfers in the parent's flavor.GIT_*_NAME/EMAILenv vars so the catalog-replay rebase works on CI runners with no global git identity.test_reemit_raises_on_missing_parent(no longer reachable given frozen ops).Test plan
🤖 Generated with Claude Code