Skip to content

Conversation

@varunagrawal
Copy link
Collaborator

Updates to GPMP2 to fix compilation and modernize to the latest GTSAM.

Fixes #28.

@varunagrawal varunagrawal requested a review from dellaert October 14, 2025 19:38
@varunagrawal varunagrawal self-assigned this Oct 14, 2025
@mattking-smith
Copy link
Collaborator

@varunagrawal did I miss something in the installation step here?

I have successfully pulled, compiled, and tested the release version on the develop branch of GTSAM.

I can build and install GPMP2, but see failures on my unit test with make check: buildCheckLog.txt.

I clearly see that the linux_ci is passing so is it because I am working in Ubuntu 20.04... Is that the issue?

On a debug branch, I almost got all the unit test working by adding

add_definitions(-D_GLIBCXX_USE_CXX11_ABI=1)
add_definitions(-DEIGEN_DONT_ALIGN_STATICALLY)

To the top-level CMakeLists.txt file in GPMP2 which I gleaned to do because I thought maybe misalignment issues with Boost and Eigen. I would be happy to hear your thoughts you have on the matter as this very well could be me missing something crucial.

Compiler config

g++ --version
g++ (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0

@varunagrawal
Copy link
Collaborator Author

Your issue is not related to the Ubuntu version. If you look at the log file you shared, it's clearly a linker issue.

Maybe try running make install on gpmp2 and running the tests again. It may be linking against an older version that you may have on your system (or trying to link from the library location).

@varunagrawal
Copy link
Collaborator Author

@dellaert CI passes!

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !!!

@dellaert dellaert merged commit 1831833 into master Oct 19, 2025
12 checks passed
@dellaert dellaert deleted the fix-build branch October 19, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to compile on Ubuntu 20.04

4 participants