Skip to content

Bound package download timeout across headers and streaming #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bound package download timeout across headers and streaming #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9a023
Initial plan
Copilot Jun 24, 2026
e8fb076
Bound package download duration with cancellation token timeout
Copilot Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,11 +981,15 @@ static async Task DownloadAndInstallPackage(string displayName, string url, stri
Logger.WriteSubProgress("Downloading from", url);
DialogManager.Instance.NotifyDownloadStarted(displayName);

using var httpClient = new HttpClient();
using var httpClient = new HttpClient
{
Timeout = Timeout.InfiniteTimeSpan
};
using var timeoutCts = new CancellationTokenSource(TimeSpan.FromMinutes(10));
var authHeader = ConfigManager.Instance.Config.AuthorizationHeader;
if (!string.IsNullOrEmpty(authHeader))
httpClient.DefaultRequestHeaders.TryAddWithoutValidation("Authorization", authHeader);
using var response = await httpClient.GetAsync(url);
using var response = await httpClient.GetAsync(url, HttpCompletionOption.ResponseHeadersRead, timeoutCts.Token);
if (!response.IsSuccessStatusCode)
{
throw new Exception($"Download failed: {response.StatusCode}");
Expand All @@ -994,8 +998,8 @@ static async Task DownloadAndInstallPackage(string displayName, string url, stri
// Ensure the file stream is completely closed before proceeding
{
await using var fileStream = File.Create(localPath);
await response.Content.CopyToAsync(fileStream);
await fileStream.FlushAsync();
await response.Content.CopyToAsync(fileStream, timeoutCts.Token);
await fileStream.FlushAsync(timeoutCts.Token);
} // fileStream is disposed here

// Add a small delay to ensure file handle is released
Expand Down