renovate: Improve config validation to catch errors #74
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Explicitly validate both renovate.json and renovate-shared-config.json - Change RENOVATE_DRY_RUN from lookup to full - Fix description fields: arrays to strings - customManagers: managerFilePatterns to fileMatch (correct field name) Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
improve-renovate-validation
branch
from
ccfd3ff to
61d730c
Compare
| - name: Validate Renovate config | ||
| - name: Validate Renovate JSON configs with schema validator | ||
| run: | | ||
| npx --yes -p renovate renovate-config-validator renovate.json |
There was a problem hiding this comment.
Isn't this potentially using a different version of renovate though than what lives in the container build?
I had been kind of hoping that we could properly use the container image in dry run mode reliably.
| uses: renovatebot/github-action@v44.2.3 | ||
| env: | ||
| RENOVATE_DRY_RUN: lookup | ||
| RENOVATE_DRY_RUN: full |
| { | ||
| "customType": "regex", | ||
| "managerFilePatterns": ["(^|/)Containerfile$", "(^|/)Dockerfile$"], | ||
| "fileMatch": ["(^|/)Containerfile$", "(^|/)Dockerfile$"], |
There was a problem hiding this comment.
Are you sure this isn't some kind of renovate-major-version drift between the validator vs the container image we use?
|
I think bigger picture if we can research and follow standard practices with what other folks are doing with renovate and reference that it'd be good. The biggest tweak we have going on here is using the self-hosted renovate via our bot token vs their hosted app. |
renovate.jsonandrenovate-shared-config.jsonRENOVATE_DRY_RUNfrom lookup to fullThe previous validation only checked
renovate.jsonand missed errors inrenovate-shared-config.json