-
Notifications
You must be signed in to change notification settings - Fork 169
Concept: point #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cxx20-concept
Are you sure you want to change the base?
Concept: point #787
Conversation
|
I am not sure what to do with the CI. Obviously all builds with cxxstd < 20 will fail. |
| /// | ||
| template <typename P> | ||
| struct PointNDConcept | ||
| concept PointNDConcept = requires(P point, typename P::template axis<0>::coord_t ft, typename P::template axis<P::num_dimensions - 1>::coord_t lt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concept should be lower case?
| } | ||
| P point; | ||
| typename P::value_type; | ||
| requires std::regular<typename P::value_type>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better write with concept conjunctions?
concept PointNDConcept = std::regular<typename P::value_type> && requires(P point, typename...
Well, any build other than c++20 will fail, no? Since GIL cannot afford the luxury of https://github.com/boostorg/cobalt, I don't know any tricks other than the old-school |
|
Right, another option would be GIL v2. |
|
If we would be allowed to consider GIL up to Boost 1.90 as last GIL that supports mixture of older and newer compilers, and any GIL released after Boost 1.90 require >= C++20, that would be great! It would be an opportunity for more thorough refactoring and better experience for implementing new features. |
Description
Switch
Pointconcept from Boost.ConceptCheck to C++20 concepts.References
Discussed on
boost-gilcpplangTasklist